First Pull Request


Calling `main` rust-lang/rust-clippy

Apart from special setups (which we could detect following attributes like `#![no_std]`), recursing into `main()` seems like an unintuitive antipattern we should be able to detect.

Created - 1 comment - C-assigned E-easy L-lint T-AST

Disable metadata server on OS X servo/saltfs

There is a metadata service on OS X that indexes files which was thrashing the disks of our OS X builders. We've disabled it for now by hand, but this should get added to Salt to prevent it from re...

Created - 2 comments - C-assigned C-has open PR E-easy

Support non-negative parsing of lengths for Either<Length, T> types servo/servo

In `components/style/values/specified/length.rs`, [we have this](https://dxr.mozilla.org/servo/rev/4c851925fbbd8446f6bfc36ff6836e9b24ad635b/components/style/values/specified/length.rs#583-614), whi...

Created - 3 comments - C-assigned E-easy I-cleanup

remove obsolete paint threads option servo/servo

Paint threads used to control how many threads we split CPU painting over. Since we no longer have CPU painting, this option is currently doing nothing and should be removed. All uses seem to be sh...

Created - 3 comments - C-assigned E-easy

Upload stylo (geckolib) docs to doc.servo.org servo/servo

The command `./mach cargo-geckolib doc` will build documentation for the `geckoservo` crate and its dependencies, in the `target/geckolib/doc` directory. It would be nice to have this run automati...

Created - 3 comments - A-documentation A-infrastructure C-assigned E-easy

Move grid types to generic module servo/servo

Lately, we've been translating most of the predefined types to generic alternatives (so that they share their `ToCss` implementations). They all live in `components/style/values/generics`. There ar...

Created - 3 comments - C-assigned E-easy I-cleanup

Style issues in components/style/properties/longhand/box.mako.rs servo/servo

There are a few occurrences of: ```rust let theta = try!(specified::Angle::parse_with_unitless(context,input)); ``` There should be a space after the comma between the arguments.

Created - 3 comments - A-content/css C-assigned E-easy

Reduce code duplication when adding a SessionHistoryChange servo/servo

The constellation has quite a few occurrences of: ```rust self.handle_load_start_msg(new_pipeline_id); self.pending_changes.push(SessionHistoryChange { top_level_browsing_context_id: top_le...

Created - 3 comments - A-constellation C-assigned E-easy I-refactor

Remove immeta dependency from net_traits servo/servo

The Cargo.toml file for components/net_traits declares a dependency on immeta, but we don't have a corresponding `extern crate` for it in the `lib.rs`. This means it is unused and can be removed. ...

Created - 3 comments - C-assigned E-easy I-cleanup

Move `Percentage` value structs to mod.rs servo/servo

Currently `Percentage` structs are in `components/style/values/{specified,computed}/length.rs`. They have been put to this file probably because many length values are using it. But they are not re...

Created - 3 comments - A-content/css C-assigned E-easy I-cleanup

Rename `TypeKind::Named` to `TypeKind::TypeParam` rust-lang/rust-bindgen

And anywhere we refer to "named" types, we should start referring to "type parameters". If you want to pick this up, just drop a comment :) I suggest starting by reading CONTRIBUTING.md and r...

Created - 3 comments - A-C++ C-assigned E-easy help wanted I-cleanup

Use `Filter buffer by name and type` algorithm implementation for all performance entry list getters servo/servo

#18176 introduces the implementation of the [Filter buffer by name and type](https://w3c.github.io/performance-timeline/#filter-buffer-by-name-and-type) algorithm. According to the [spec](https://w...

Created - 3 comments - A-content/dom C-assigned E-easy

Prevent reentrancy in TreeWalker::accept_node and NodeIterator::accept_node servo/servo

accept_node implements the [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from the specification, but that algorithm has been updated since it was first written. We need to ad...

Created - 3 comments - A-content/dom C-assigned E-easy

Performance observer must replace observer if it's already present servo/servo

It seems that we are not implementing [step 3](https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe()) from the `PerformanceObserver.observe()` method spec properly. Test:...

Created - 3 comments - A-content/dom C-assigned E-easy

Remove integrity check for no-cors requests servo/servo

The Fetch specification has been updated to allow non-empty integrity strings for requests that are marked as no-cors: https://github.com/whatwg/fetch/pull/584 We should remove the corresponding...

Created - 3 comments - A-network C-assigned E-easy I-spec-update

Replace manual implementations of Runnable::name with automatic type name servo/servo

We have a [Runnable](https://doc.servo.org/script/script_thread/trait.Runnable.html) trait with a name method. This method is used to improve profiling output so we can tell at runtime which concre...

Created - 3 comments - A-content/script C-assigned E-easy I-refactor

Make BindgenOptions be pub(crate) rust-lang/rust-bindgen

Its public use has been deprecated for a while now, and it is only meant for internal use.

Created - 3 comments - C-assigned E-easy help wanted I-cleanup

Add a `Builder::blacklist_type` method; deprecate `Builder::hide_type` rust-lang/rust-bindgen

Currrently, the `--blacklist-type` flag's corresponding `Builder` method is `Builder::hide_type`. The naming difference is unnecessary, inconsistent, makes it harder for users to switch from CLI...

Created - 3 comments - C-assigned E-easy enhancement help wanted I-cleanup

Make fire_mouse_event accept an enum instead of a string argument servo/servo

We only use the `fire_mouse_event` method for specific kinds of mouse events, so it should accept a stronly-typed enum that can be converted into an appropriate string value. Code: `components/s...

Created - 3 comments - A-content/dom C-assigned E-easy I-cleanup

Builder::command_line_flags misgenerates rust target's flag rust-lang/rust-bindgen

It should add `["--rust-target", "1.19"]` but only adds the second part. See the `command_line_flags` method of `Builder` in `src/lib.rs`. There are some tests that can be extended at the bot...

Created - 3 comments - C-assigned E-easy help wanted

GamepadButtonList::sync_from_vr should use more iterators servo/servo

Instead of using an index variable and unwrapping the result of calling `get`, we should use the [zip](https://doc.servo.org/core/iter/trait.Iterator.html#method.zip) iterator method to iterate ove...

Created - 3 comments - A-webvr C-assigned E-easy I-cleanup

Default to generating constified enums, rather than generating Rust enums servo/rust-bindgen

Right now, we translate C/C++ enums into Rust enums by default. This is problematic because it is OK for C/C++ code to return some `int` that *isn't* one of the enum variants, and that is well defi...

Created - 3 comments - C-assigned E-easy help wanted

Stop passing `whitelisted_items` as an argument to the codegen functions, and use ctx.codegen_ite... servo/rust-bindgen

This was computed on the fly before and passed as an argument. Now we precompute it in `context.rs`, and just pass `codegen_items()` as an argument. We should be able to remove that argument alt...

Created - 3 comments - C-assigned E-easy help wanted I-cleanup

counter-reset and counter-increment should serialize empty vec to "none" rather than empty servo/servo

The code to fix is https://github.com/servo/servo/blob/d30978246162e8a9bfad42b43ab6a05c90421c6e/components/style/properties/longhand/counters.mako.rs#L270-L281 It should generate `none` rather t...

Created - 4 comments - A-content/css A-stylo C-assigned E-easy

tidy: Make tidy check that opening and closing braces that begin a line do so with proper alignment. servo/servo

I think it makes sense if we enforce the invariant that at least a `{` or `}` that begins a line should do so with a multiple of 4 spaces to the left. That'd prevent stuff like https://github.com/s...

Created - 4 comments - C-assigned E-easy L-python

Make no_viewport_percentage! use an absolute path for HasViewportPercentage servo/servo

Currently to use `no_viewport_percentage!`, one needs to first import the `HasViewportPercentage` trait in scope. This is a paper cut.

Created - 4 comments - A-content/css C-assigned E-easy I-papercut

RestyleReplacements unused in components/script/dom/document.rs servo/servo

``` warning: unused import: `RestyleReplacements` --> /home/manfred/src/servo/components/script/dom/document.rs:134:41 | 134 | use style::restyle_hints::{RestyleHint, RestyleReplacements...

Created - 4 comments - A-content/script C-assigned E-easy I-cleanup

Document bitfield usage in the users guide rust-lang/rust-bindgen

Similar to the section on using unions, we should have a section on using bitfields.

Created - 4 comments - A-bitfields C-assigned E-easy I-needs-docs

Remove rendering_threads option in the CEF port. servo/servo

https://github.com/servo/servo/pull/17872 is removing its only user. Once it lands we can remove it without problems. The field is in `ports/cef/types.rs`, I don't think this would require more ...

Created - 4 comments - A-embedding C-assigned E-easy I-cleanup

Add `Builder::whitelist_function`; deprecate `Builder::whitelisted_function` rust-lang/rust-bindgen

The CLI flag is `--whitelist-function`, so we should be consistent and remove the "ed" from the builder method. * [ ] Rename `Builder::whitelisted_function` to `Builder::whitelist_function` * [...

Created - 4 comments - C-assigned E-easy enhancement help wanted I-cleanup

Displaying issues 1 - 30 of 108 in total

License

Language