First Pull Request


Errors from Visitor should point to beginning of the object serde-rs/json

In the following string validation, the error message points to the close quote after "test123". It would be nicer to point to the opening quote instead. ```rust #[macro_use] extern crate serd...

Created - 0 comments - bug good first issue

Improve panic messages when runtime is not running tokio-rs/tokio

The panic messages when the reactor or timer are not available should be improved to better explain what a user needs to do to fix them (originally reported at https://github.com/hyperium/hyper/iss...

Created - 0 comments - easy

Lint: Multiple inherent impls rust-lang/rust-clippy

We may want to have a lint that checks for [multiple inherent impls](https://play.rust-lang.org/?gist=5798fd8736e09adb74da&version=stable). Why those are not problematic from a language standpoint,...

Created - 0 comments - E-easy L-lint T-AST

suggest struct constructor instead of mutable object + field mod rust-lang/rust-clippy

If you have a struct where all fields are public, then you should never do `let mut a = A::default(); a.x = 42;` but instead use a constructor with `.. A::default()` at the end: ``` rust #[derive(...

Created - 0 comments - E-easy L-lint T-AST

lint: transmuting known null pointer to ref rust-lang/rust-clippy

`mem::transmute(std::ptr::null())` – this is undefined behavior.

Created - 0 comments - E-easy L-lint T-AST

collapsible_if shouldn't apply if there is a comment before rust-lang/rust-clippy

In this example there is comment which applies to both branches in the `else` block. ``` if entry.end > entry.base { prev = entry_; // Go to the next entry } else { ...

Created - 0 comments - E-easy L-enhancement

improve collapsible if in complex cases with same expressions rust-lang/rust-clippy

``` rust if a { if b { f(); } } else { f(); } ``` could be ``` rust if !a || b { f(); } ```

Created - 0 comments - E-easy L-enhancement L-lint

float_cmp: ignore when comparing with constant? rust-lang/rust-clippy

Consider: ``` const ONE: f32 = 1.0; fn main() { let v = 0.9; let _ = v == ONE; } ``` These are probably cases where you want to check for the exact constant, because it is a common argume...

Created - 0 comments - E-easy L-enhancement

Lint std::panic::catch_unwind rust-lang/rust-clippy

<!-- Hi there! Whether you've come to make a suggestion for a new lint, an improvement to an existing lint or to report a bug or a false positive in Clippy, you've come to the right place. If you ...

Created - 0 comments - L-lint T-AST good first issue hacktoberfest

Lint: Implicit Deref rust-lang/rust-clippy

Basically, an `#[allow]` by default lint that tells you when you are referencing a value implicitly (e.g. `String::new().chars()` is really `(*String::new()).chars()`. Rationale is that somebody o...

Created - 0 comments - E-easy L-lint T-middle

Lint to warn about str::as_ptr() usage in ffi call rust-lang/rust-clippy

Hello. It would be nice to have a warning when using `str::as_ptr()` in a ffi call instead of using `CStr`. For instance, in the following code: ``` rust unsafe { printf("Hello".as_ptr() as *cons...

Created - 0 comments - A-correctness E-easy L-lint T-middle

Add topics to GitHub rust-lang/rust-clippy

See https://github.com/blog/2309-introducing-topics. Looks like only the owner can do that @Manishearth smile We should have *Rust* and *linter* at least.

Created - 0 comments - E-easy L-documentation

FR: redundant_field_names should distinguish between all and some fields matching rust-lang/rust-clippy

`redundant_field_names` fires on any field being a match. This impairs readability in cases like this: ```rust let thingy = Thingy { calc: big + calculation, redundant: redundant, o...

Created - 0 comments - A-style L-enhancement good first issue

Lint suggestion: Useless explicit documentation link rust-lang/rust-clippy

Once [intra-rustdoc links](https://github.com/rust-lang/rfcs/blob/master/text/1946-intra-rustdoc-links.md) lands, many explicit links will become unnecessary. It would be very useful to have a lint...

Created - 0 comments - A-style L-lint good first issue

Docs: Create a page with info on how to do common things rust-lang/rust-clippy

After https://github.com/rust-lang/rust-clippy/pull/3824, it would be nice to continue adding documentation. Specifically, it would be awesome to have a page that explains some common lint writing ...

Created - 0 comments - L-documentation good first issue

Suggest `resize` rather when pushing same item to vec rust-lang/rust-clippy

Example in https://github.com/Gymmasssorla/finshir/blob/eae5d0c6761f5558c8ed33ef098d8bd13a07e64f/src/testing/helpers.rs#L55-L61 When pushing the same item to vec. ```rust fn gen_portions() -...

Created - 0 comments - A-complexity L-lint good first issue

many_single_char_names incorrectly triggered if 'single-char-binding-names-threshold = 0' rust-lang/rust-clippy

As I don't want to allow ANY variable names with only one character, I have the following `clippy.toml`: ``` single-char-binding-names-threshold = 0 ``` Additionally, I run clippy with `-- ...

Created - 0 comments - A-musing L-bug :beetle: good first issue

type_repetition_in_bounds should not trigger on macro-generated code rust-lang/rust-clippy

See an example from Serde in https://github.com/serde-rs/serde/issues/1595. I consider this a false positive because in code generators we optimize for readability of the macro code, not readabi...

Created - 0 comments - L-bug :beetle: T-macros good first issue

Support for upcoming `param_attrs` feature rust-lang/rust-clippy

[`param_attrs` is likely to be stabilized in Rust 1.39](https://github.com/rust-lang/rust/pull/64010) The `param_attrs` feature is going to allow lint attributes on function, method and closure...

Created - 0 comments - C-needs-discussion L-enhancement good first issue needs test

Suggestion: borrowing a RefCell in funarg position rust-lang/rust-clippy

<!-- Hi there! Whether you've come to make a suggestion for a new lint, an improvement to an existing lint or to report a bug or a false positive in Clippy, you've come to the right place. For ...

Created - 0 comments - L-lint T-middle good first issue

[Tracking issue] Update Contributing and docs after #4650 rust-lang/rust-clippy

After #4650, [CONTRIBUTING.md][1] and [doc][2] does not reflect current guide on how to write correct lint for new contributors. We should update it. [1]: https://github.com/rust-lang/rust-clip...

Created - 0 comments - L-documentation good first issue help-wanted

New lint: Use `Into`/`TryInto` in bounds as opposed to `From`/`TryFrom` rust-lang/rust-clippy

When writing generic bounds such as: ```rust fn foo<T>(a: T) where u32: From<T>; ``` `Into` should be preferred, like this: ```rust fn foo<T>(a: T) where T: Into<u32>; ``` Why the f...

Created - 0 comments - A-style L-lint good first issue

Make example_generated agree with the big example in the crate docs rust-lang-nursery/error-chain

There are two big examples in this crate - the one in the crate-level docs, and the one in the `example_generated` module; and they are not the same. Make them the same: start from the one in the c...

Created - 0 comments - easy help wanted

log: Cache interests tokio-rs/tracing

## Feature Request ### Crates `tokio-trace-log` ### Motivation Currently, after #70, the `LogTracer` struct in `tokio-trace-log` will call `Subscriber::enabled` every time an event occurs...

Created - 0 comments - crate/log good first issue kind/feature

tracing: Consider adding a prelude tokio-rs/tracing

## Feature Request ### Crates `tracing` ### Motivation It might be useful for the `tracing` crate to expose a prelude containing commonly used types, traits, functions, macros, etc. ...

Created - 0 comments - crate/tracing good first issue kind/feature kind/rfc needs/design

futures: support futures 0.3 Streams/Sinks tokio-rs/tracing

## Feature Request ### Crates `tracing-futures` ### Motivation `tracing-futures` currently supports instrumenting `futures` 0.1 `Future`s, `Stream`s, and `Sink`s, and `std::future::Futu...

Created - 0 comments - crate/futures good first issue kind/feature

async/await versions of examples tokio-rs/tracing

## Feature Request ### Crates + `tracing-futures` + `tracing-tower` + `tracing-env-logger` ### Motivation Currently, we have a `nightly-examples` directory with examples of code using...

Created - 0 comments - crate/futures crate/tower good first issue kind/docs

async/await versions of examples tokio-rs/tracing

## Feature Request ### Crates + `tracing-futures` + `tracing-tower` + `tracing-env-logger` ### Motivation Currently, we have a `nightly-examples` directory with examples of code using...

Created - 0 comments - crate/futures crate/tower good first issue kind/docs

Left recursion not detected pest-parser/pest

The validator admits this left-recursive rule: ``` r = { (r | "") ~ "." } ``` But `r ~ "."` and `r | ""` fail to compile, as expected.

Created - 0 comments - bug good-first-issue meta

Displaying issues 1 - 30 of 1163 in total

License

Language

Labels