First Pull Request


New "enforcing" option: `oldie` jshint/jshint

Currently, JSHint issues some warnings that relate to peculiarities of outdated versions of the Internet Explorer browser: - `W002`: "Value of '{a}' may be overwritten in IE 8 and earlier." (is...

Created - 0 comments - good first bug Proposal

Rack::Protection more examples in docs sinatra/sinatra

/cc sinatra/rack-protection#55

Created - 0 comments - docs rack-protection your-first-pr

Document sharing sessions sinatra/sinatra

Perhaps this is already covered somewhere, but worth looking into. Especially with regards to Rack::Protection and Sinatra sessions. /cc sinatra/rack-protection#107 and sinatra/rack-protection#83

Created - 0 comments - docs rack-protection your-first-pr

#runInstall expose command if failed yeoman/generator

If the #runInstall spawn fails (or skipInstall is set) it should log what the command would have run so the user can run it on their own. This would include things like `--save-dev`

Created - 0 comments - actionnable easy feature

[feature request] Add INFORMATION_SCHEMA.COLUMNS CHARACTER_MAXIMUM_LENGTH sequelize/sequelize

Add INFORMATION_SCHEMA.COLUMNS CHARACTER_MAXIMUM_LENGTH to the describeTableQuery so that we can then use it in sequelize-auto or whatever project, to get the max length of a given field.

Created - 0 comments - feature good-first-pr mysql

support relative templates in the browser mozilla/nunjucks

I just realized that relative templates don't work in the browser because they depend on node's `path.resolve` function. We need something like it in the browser. I added a message saying they don'...

Created - 0 comments - bug good first bug

Investigate using IndexedDB Observers for change events pouchdb/pouchdb

This has landed in Chrome Canary: https://github.com/WICG/indexed-db-observers We should experiment and see if this can replace our localStorage-based events. In theory this system should work b...

Created - 0 comments - enhancement good first patch help wanted

Add support for "module" as well as "jsnext:main" pouchdb/pouchdb

I can't see any reason not to support both of these. This should just be a change to our build/publish process to add a `"module"` entry as well as a `"jsnext:main"` one.

Created - 0 comments - enhancement good first patch help wanted

find() should throw unsupported_mixed_sort error for mixed asc/desc pouchdb/pouchdb

Here's a test that succeeds for CouchDB 2.0 but fails for PouchDB (e.g. when added to `tests/find/test-suite-1/test.errors.js`): ```js it('throws an error for incompatible sort', function (...

Created - 0 comments - bug good first patch has test case

initial values for .editable-fields yabwe/medium-editor

I struggled upon a small problem: If you start with an empty .editable-field, the .editable-field is much smaller due to the missing html-tags ``` <p><br class="_moz"></p> ``` So if you sta...

Created - 0 comments - easy first bug

Frozen string literal should be a new object if String#freeze is redefined jruby/jruby

I added "foo".freeze support recently, but I did not put in a check if String#freeze has been overridden. That leads to a failure in this test from ruby/test_optimization.rb: ``` ruby def test_s...

Created - 0 comments - beginner core ir jit JRuby 9000

getHomeDirectoryPath fails when ENV is stubbed (RSpec) jruby/jruby

How to reproduce: ``` ruby class Foo; def self.[](name); ENV[name]; end; end Object.__send__(:remove_const, 'ENV') Object.const_set('ENV', Foo) File.expand_path('~/anything') # works as expected...

Created - 0 comments - beginner JRuby 1.7.x JRuby 9000

JRUBY_5122 regression spec "write should not block" tests nothing jruby/jruby

The spec for "should not block for write" [JRUBY-5122 TCPSocket regression spec](https://github.com/jruby/jruby/blob/master/spec/regression/JRUBY-5122_nonblocking_io_spec.rb) does not appear to tes...

Created - 0 comments - beginner tests

Backport recent File.expand_path and basename encoding fixes jruby/jruby

As requested by @enebo we should try to backport the fixes for #3877 and #3866 to 1.7. The #3866 fix is mostly isolated from joni transcoding, but the #3877 fix would require 1.7 to start using jo...

Created - 0 comments - beginner cext encoding JRuby 1.7.x

Use 'Prettier' on the Draft.js codebase facebook/draft-js

See https://github.com/prettier/prettier

Created - 0 comments - enhancement good-first-bug

Most motor controller diagrams use shields which is not helpful rwaldron/johnny-five

At the very least we need 2-wire, 3-wire and 2-wire+enable examples that DO NOT use shields. You can't actually see any wiring so the diagrams are worthless.

Created - 0 comments - Class:Motor DOCS easy help-wanted

Hide private subgenerator namespaces yeoman/yo

With composability becoming more common, we end up with some very specific subgenerators that may clutter the `yo gen --help` interface. We should probably offer a way to hide some "private" subgen...

Created - 0 comments - actionnable easy feature ready

Lint: Multiple inherent impls Manishearth/rust-clippy

We may want to have a lint that checks for [multiple inherent impls](https://play.rust-lang.org/?gist=5798fd8736e09adb74da&version=stable). Why those are not problematic from a language standpoint,...

Created - 0 comments - E-easy L-lint T-AST

Add interpolation tests tweenjs/tween.js

There's a nice // TODO in the unit tests file, asking for tests for the interpolation feature (tween.interpolation(Linear/Bezier/Catmull-Rom))

Created - 0 comments - good first bug HELP NEEDED

suggest struct constructor instead of mutable object + field mod Manishearth/rust-clippy

If you have a struct where all fields are public, then you should never do `let mut a = A::default(); a.x = 42;` but instead use a constructor with `.. A::default()` at the end: ``` rust #[derive(...

Created - 0 comments - E-easy L-lint T-AST

lint: transmuting known null pointer to ref Manishearth/rust-clippy

`mem::transmute(std::ptr::null())` – this is undefined behavior.

Created - 0 comments - E-easy L-lint T-AST

Uncaught exceptions in browsers without webrtc support feross/webtorrent

There's an "Error: No WebRTC support: Not a supported browser" exception in Safari. Visible on https://webtorrent.io. We can handle this more gracefully, which has the excellent side benefit of ma...

Created - 0 comments - browser good first contribution help wanted

collapsible_if shouldn't apply if there is a comment before Manishearth/rust-clippy

In this example there is comment which applies to both branches in the `else` block. ``` if entry.end > entry.base { prev = entry_; // Go to the next entry } else { ...

Created - 0 comments - E-easy L-enhancement

improve collapsible if in complex cases with same expressions Manishearth/rust-clippy

``` rust if a { if b { f(); } } else { f(); } ``` could be ``` rust if !a || b { f(); } ```

Created - 0 comments - E-easy L-enhancement L-lint

doc_markdown should ignore things which just contain acronyms Manishearth/rust-clippy

Instead of needing to manually whitelist, we should ignore things like `DirectX` and `OpenGL`. For something to be camel case, it should have at least two camelcase words in it, each which have at ...

Created - 0 comments - E-easy L-enhancement

float_cmp: ignore when comparing with constant? Manishearth/rust-clippy

Consider: ``` const ONE: f32 = 1.0; fn main() { let v = 0.9; let _ = v == ONE; } ``` These are probably cases where you want to check for the exact constant, because it is a common ...

Created - 0 comments - E-easy L-enhancement

float_cmp: ignore when comparing with constant? Manishearth/rust-clippy

Consider: ``` const ONE: f32 = 1.0; fn main() { let v = 0.9; let _ = v == ONE; } ``` These are probably cases where you want to check for the exact constant, because it is a common argume...

Created - 0 comments - E-easy L-enhancement

Lint suggestion: Calling .ok() unnecessary in if let Manishearth/rust-clippy

<!-- Hi there! Whether you've come to make a suggestion for a new lint, an improvement to an existing lint or to report a bug or a false positive in Clippy, you've come to the right place. If y...

Created - 0 comments - A-unnecessary E-easy L-lint T-middle

Lint std::panic::catch_unwind Manishearth/rust-clippy

<!-- Hi there! Whether you've come to make a suggestion for a new lint, an improvement to an existing lint or to report a bug or a false positive in Clippy, you've come to the right place. If you ...

Created - 0 comments - E-easy L-lint T-AST

lint usage of struct constructors when new/from method is available Manishearth/rust-clippy

if a struct has a `new` or a `from` method that does the same as a struct constructor, then that method should be used instead of the struct constructor. Obviously the usage of a struct construc...

Created - 0 comments - A-style E-easy L-lint T-middle

Displaying issues 1 - 30 of 3183 in total