These are my settings for ESLint and Prettier
You might like them - or you might not. Don't worry you can always change them.
- Lints JavaScript and TypeScript based on the latest standards
- Fixes issues and formatting errors with Prettier
- Lints + Fixes inside of html script tags
- Lints + Fixes React via eslint-config-airbnb
- You can see all the rules here. You are very welcome to overwrite any of these settings, or just fork the entire thing to create your own.
It's recommended you install this once per every project. ESLint used to have global configs, but no longer.
-
If you don't already have a
package.json
file, create one withyarn init -y
. -
Then we need to install this config
npm install eslint-config-kiprasmel
- We need to put our eslint settings in a file in the root of your project. I prefer to use our existing
package.json
, and add aneslintConfig
property. You can also create a new.eslintrc
or.eslintrc.js
file that lives where package.json does:
in package.json, add this anywhere top level. Like right under your "scripts" object.
"eslintConfig": {
"extends": ["kiprasmel"]
}
Or put this in a .eslintrc
file
{
"extends": ["kiprasmel"]
}
TypeScript users will also need a tsconfig.json
file in their project.
- You can add two scripts to your package.json to lint and/or fix:
"scripts": {
"lint": "eslint .",
"lint:fix": "eslint . --fix"
},
- Now you can manually lint your code by running
yarn lint
and fix all fixable issues withyarn lint:fix
. You probably want your editor to do this though.
If you'd like to overwrite eslint or prettier settings, you can add the rules in your .eslintrc
file. The ESLint rules go directly under "rules"
.
{
"extends": [
"kiprasmel"
],
"rules": {}
}
You can put this in your ESLint config as a rule like so:
{
"extends": ["kiprasmel"],
"rules": {
... any eslint rules here
"prettier/prettier": [
"error",
{
"singleQuote": true,
"endOfLine": "auto",
"tabWidth": 4
},
],
}
}
Note if you are switching to double quotes, you'll also need to add this eslint rule, or they will fight to the death!
quotes: ["error", "double"];
You should read this entire thing. Serious!
Once you have done one, or both, of the above installs. You probably want your editor to lint and fix for you. Here are the instructions for VS Code:
- Install the ESLint package
- Now we need to setup some VS Code settings via
Code/File
→Preferences
→Settings
. It's easier to enter these settings while editing thesettings.json
file, so click the Open (Open Settings) icon in the top right corner:
"editor.formatOnSave": true,
// turn it off for JS and JSX, we will do this via eslint
"[javascript][javascriptreact][typescript][typescriptreact]": {
"editor.formatOnSave": false
},
// tell the ESLint plugin to run on save
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
},
{
"editor.formatOnSave": true,
"eslint.enable": true,
"editor.codeActionsOnSave": {
"source.fixAll": "explicit",
"source.fixAll.eslint": "always"
},
"eslint.run": "onSave",
"eslint.format.enable": true,
"[javascript]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
},
"[javascriptreact]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
},
"[typescript]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
},
"[typescriptreact]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
},
"prettier.disableLanguages": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
}
After attempting to lint your file for the first time, you may need to click on 'ESLint' in the bottom right and select 'Allow Everywhere' in the alert window.
Finally you'll usually need to restart VS code. They say you don't need to, but it's never worked for me until I restart.
- Run
npx install-peerdeps --dev eslint-config-kiprasmel
- Crack open your
package.json
and replace"extends": "react-app"
with"extends": "kiprasmel"
- Add
DISABLE_ESLINT_PLUGIN=true
to the "start" script, see wesbos#140 (comment)
- Run
npx install-peerdeps --dev eslint-config-kiprasmel
- follow the
Local / Per Project Install
steps above
It should work as above.
If you have previously configured ESLint to run via a File Watcher, turn that off.
- Open ESLint configuration by going to File > Settings (Edit > Preferences on Mac) > Languages & Frameworks > Code Quality Tools > ESLint (optionally just search settings for "eslint")
- Select Automatic ESLint Configuration
- Check Run eslint --fix on save
The following steps are for a typical Node / ESLint global installtion. If you have a customized setup, refer to JetBrains docs for more ESLint Configuration Options.
- Open ESLint configuration by going to File > Settings (Edit > Preferences on Mac) > Languages & Frameworks > Code Quality Tools > ESLint (optionally just search settings for "eslint")
- Select Manual ESLint configuration
- Choose your Node interpreter from the detected installations
- Select the global ESLint package from the dropdown
- Leave Configuration File as Automatic Search
- Check Run eslint --fix on save
- Open Prettier configuration by going to File > Settings (Edit > Preferences on Mac) > Languages & Frameworks > Code Quality Tools > Prettier (optionally just search settings for "prettier")
- Uncheck both On code reformat and On save
-
Optional BUT IMPORTANT: If you have the Prettier extension enabled for other languages like CSS and HTML, turn it off for JS since we are doing it through Eslint already.
- Make sure the Run for files glob does not include
js,ts,jsx,tsx
. - An example glob for styles, config, and markdown.
{**/*,*}.{yml,css,sass,md}
- Make sure the Run for files glob does not include
Same instructions as above.
If you experience issues with ESLint not formatting the code or you receive a Parsing error: Cannot find module '@babel/preset-react
error message then you need to check that you opened the folder where you installed and configured ESLint directly in VS Code. The correct folder to open will be the one where you installed the eslint-config-kiprasmel
npm package and where you created the .eslintrc
file.
Opening a parent folder or child folder in your code editor will cause ESLint to fail in finding the ESLint npm packages and the formatting won't work.
your-username
|
projects
|
beginner-javascript # <- Open this folder directly in your code editor
.eslintrc
package.json
node_modules/
exercises/
playground/